[host] Copy hostfxr and hostpolicy for Mono also, if !mobile #73633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the mono "HelloWorld" sample (src/mono/samples/HelloWorld) on desktop platforms
|
Tagging subscribers to this area: @directhex Issue DetailsFixes the mono "HelloWorld" sample (src/mono/samples/HelloWorld) on desktop platforms
|
directhex
approved these changes
Aug 9, 2022
ViktorHofer
reviewed
Aug 9, 2022
Comment on lines
+98
to
+100
| <!-- copy the host files to make the desktop samples work --> | ||
| <RuntimeFiles Include="@(HostFxrFile)" Condition="Exists('@(HostFxrFile)') and '$(TargetsMobile)' != 'true'"/> | ||
| <RuntimeFiles Include="@(HostPolicyFile)" Condition="Exists('@(HostPolicyFile)') and '$(TargetsMobile)' != 'true'" /> |
There was a problem hiding this comment.
These files are already copied above in L48-56. @agocke can you please take a look?
There was a problem hiding this comment.
that's for the test host.
The change in this PR is for the "runtime pack" that is used by eng/targetingpacks.targets
ViktorHofer
requested changes
Aug 9, 2022
There was a problem hiding this comment.
Let's wait for @agocke's review as he just recently made the same change just a bit differently.
ghost
added
needs-author-action
This comment was marked as off-topic.
This comment was marked as off-topic.
ViktorHofer
approved these changes
Aug 9, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the mono "HelloWorld" sample (src/mono/samples/HelloWorld) on desktop platforms